Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update brief descriptions of function purpose, Closes #230 #831

Merged
merged 1 commit into from
May 24, 2023

Conversation

weslleyspereira
Copy link
Collaborator

@weslleyspereira weslleyspereira commented May 23, 2023

Closes #230.

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1fafb88) 0.00% compared to head (6482d84) 0.00%.

❗ Current head 6482d84 differs from pull request most recent head 48adc21. Consider uploading reports for the commit 48adc21 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           master     #831    +/-   ##
========================================
  Coverage    0.00%    0.00%            
========================================
  Files        1908     1908            
  Lines      187072   186958   -114     
========================================
+ Misses     187072   186958   -114     
Impacted Files Coverage Δ
SRC/cgbsvx.f 0.00% <ø> (ø)
SRC/cgebal.f 0.00% <0.00%> (ø)
SRC/cgees.f 0.00% <ø> (ø)
SRC/cgeesx.f 0.00% <ø> (ø)
SRC/cgeev.f 0.00% <ø> (ø)
SRC/cgeevx.f 0.00% <ø> (ø)
SRC/cgejsv.f 0.00% <ø> (ø)
SRC/cgels.f 0.00% <ø> (ø)
SRC/cgelsd.f 0.00% <ø> (ø)
SRC/cgelss.f 0.00% <ø> (ø)
... and 234 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@martin-frbg martin-frbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but may I suggest changing the title of this PR to something more descriptive before merging, like "update brief descriptions of function purpose" ? That way "git log" and anything derived from it would make a lot more sense without having to dig back to the issue this closes...

@langou langou changed the title Closes #230 update brief descriptions of function purpose, Closes #230 May 24, 2023
@langou
Copy link
Contributor

langou commented May 24, 2023

may I suggest changing the title of this PR to something more descriptive before merging, like "update brief descriptions of function purpose" ?

done

@langou langou merged commit 971b058 into Reference-LAPACK:master May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants