Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster Travis CI builds #591

Merged
merged 2 commits into from
Sep 22, 2019
Merged

Conversation

DeeDeeG
Copy link
Contributor

@DeeDeeG DeeDeeG commented Aug 20, 2019

Context

  • Implements ideas laid out in this comment:
  • Makes builds go faster at Travis-ci.com without negatively impacting development (and without any impact on production whatsoever, since we don't use Docker or Travis CI in production).

Summary of Changes

  • Use the minimal language for Travis CI, instead of the ruby language.
  • Use the smaller postgresql:alpine base image for our Docker database container, instead of the generic postgresql image, which is based on debian.

Checklist

  • Tested Mobile Responsiveness
  • Added Unit Tests
  • CI Passes
  • Deploys to Heroku on test Correctly (Maintainers will handle)
  • Added Documentation (Service and Code when required)

@DeeDeeG
Copy link
Contributor Author

DeeDeeG commented Sep 14, 2019

Would also like to merge this PR this weekend.

- DeeDeeG

@DeeDeeG
Copy link
Contributor Author

DeeDeeG commented Sep 22, 2019

Also merging this today.

We do all the setup/build steps inside a Docker container,
so we don't need ruby tools outside of Docker
(on the Travis CI virtual machine instances).

Should save about 20 seconds of Travis CI build time.

--

Inspired by @btyy77c who did this first at their dockerAlpine branch:
  - btyy77c@393cf46

Documentation at Travis re: minimal/generic images:
  - https://docs.travis-ci.com/user/languages/minimal-and-generic/
This (the Alpine Linux-based postgresql image) is a smaller image
than the debian-based postgresql image,
so it should be marginally faster to download.

Seems like a good idea in general,
to speed up build times (even outside of Travis CI).

Also should save some disk space for developers.

--

Inspired by the general concept of @btyy77c's dockerAlpine branch:
  - https://github.com/btyy77c/refugerestrooms/commits/dockerAlpine

Docker Hub documentation on the alpine vs debian postgres images:
  - https://hub.docker.com/_/postgres#image-variants
@DeeDeeG DeeDeeG merged commit c6cf8d9 into RefugeRestrooms:develop Sep 22, 2019
@mi-wood mi-wood mentioned this pull request Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant