Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity Framework Logging Behaviour #439

Closed
statler opened this issue Dec 5, 2021 · 2 comments
Closed

Entity Framework Logging Behaviour #439

statler opened this issue Dec 5, 2021 · 2 comments
Labels
bug Issues describing a bug or pull requests fixing a bug.

Comments

@statler
Copy link

statler commented Dec 5, 2021

Describe the bug

The docs describe the known issue with logging of the whole database as below:

WARNING: In older versions of Serilog.Exceptions, if you are using EntityFrameworkCore with Serilog.Exceptions you must add this, otherwise in certain cases your entire database will be logged! This is because the exceptions in Entity Framework Core have properties that link to the entire database schema in them (See #100, dotnet/efcore#15214). Newer versions of Serilog.Exceptions avoids this issue by preventing the destructure of properties that implement IQueryable preventing their execution.

In older versions of Serilog.Exceptions Can you please clarify what versions this is necessary for. 'Older versions' is not definitive or informative. Is it still a requirement or not.

Steps to reproduce

View the docs

Expected behaviour

The requirement for what versions the additional library is required for should be explicit, or at least definitive about whether the issue is present in the current build.

@statler statler added the bug Issues describing a bug or pull requests fixing a bug. label Dec 5, 2021
@RehanSaeed
Copy link
Owner

This was the PR that had the fix in it:

This made it into the 8.0.0 release:

Documentation updated.

@statler
Copy link
Author

statler commented Dec 7, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues describing a bug or pull requests fixing a bug.
Projects
None yet
Development

No branches or pull requests

2 participants