Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not destructure Uri objects #46

Closed
cd21h opened this issue Jan 22, 2018 · 1 comment
Closed

Do not destructure Uri objects #46

cd21h opened this issue Jan 22, 2018 · 1 comment
Assignees
@cd21h
Labels
enhancement Issues describing an enhancement or pull requests adding an enhancement. help wanted Help wanted from the community.

Comments

@cd21h
Copy link
Contributor

cd21h commented Jan 22, 2018

When logging exception data, write Uri object as string, not destructure it.
@RehanSaeed RehanSaeed added enhancement Issues describing an enhancement or pull requests adding an enhancement. help wanted Help wanted from the community. labels Jan 23, 2018
@RehanSaeed
Copy link
Owner

Open for a PR

cd21h added a commit to alphacloud/Serilog.Exceptions that referenced this issue Jan 23, 2018
@cd21h
Represent Uri as string, not destructure it, closes RehanSaeed#46
b608fd2
@krajek krajek closed this as completed in 55af49d Jan 27, 2018
krajek added a commit that referenced this issue Jan 27, 2018
@krajek
Merge pull request #48 from alphacloud/feature/46-uri Represent Uri a…
4b75483 
…s string

Represent Uri as string, not destructure it, closes #46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cd21h cd21h

Labels
enhancement Issues describing an enhancement or pull requests adding an enhancement. help wanted Help wanted from the community.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cd21h @RehanSaeed