Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SocketExceptionDestructurer #249 #253

Merged
merged 3 commits into from
Nov 3, 2020
Merged

Added SocketExceptionDestructurer #249 #253

merged 3 commits into from
Nov 3, 2020

Conversation

TysonMN
Copy link
Contributor

@TysonMN TysonMN commented Oct 20, 2020

Resolves #249

I decided to keep things simple by only adding properties for SocketErrorCode and its documentation.

The properties and inheritance hierarchy varies for SocketException depending on the target runtime. For example, it has properties ErrorCode and NativeErrorCode and the inheritance hierarchy is

Exception -> SystemException -> ExternalException -> Win32Exception -> SocketException

when targeting .NET Core 3.1 and no other properties (other than those on Exception and SocketErrorCode on SocketException itself) and the inheritance hierarchy is just

Exception -> SocketException

when targeting .NET Standard 1.6.

RehanSaeed
RehanSaeed reviewed Nov 2, 2020
View reviewed changes
Copy link
Owner

@RehanSaeed RehanSaeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. Looks good. Just a couple of questions about possible improvements.

Source/Serilog.Exceptions/Destructurers/SocketExceptionDestructurer.cs Outdated Show resolved Hide resolved
Source/Serilog.Exceptions/Destructurers/SocketExceptionDestructurer.cs Outdated Show resolved Hide resolved
Tests/Serilog.Exceptions.Test/Destructurers/SocketExceptionDestructurerTest.cs Outdated Show resolved Hide resolved
@RehanSaeed RehanSaeed added enhancement Issues describing an enhancement or pull requests adding an enhancement. minor Pull requests requiring a minor version update according to semantic versioning. labels Nov 2, 2020
@RehanSaeed
Copy link
Owner

Looks good. Will merge as soon as the checks go green.

@RehanSaeed RehanSaeed merged commit 817a9ba into RehanSaeed:master Nov 3, 2020
@TysonMN TysonMN deleted the 249_SocketExceptionDestructurer branch November 11, 2020 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RehanSaeed RehanSaeed RehanSaeed left review comments

Assignees
No one assigned
Labels
enhancement Issues describing an enhancement or pull requests adding an enhancement. minor Pull requests requiring a minor version update according to semantic versioning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add destructurer for SocketException
2 participants
@TysonMN @RehanSaeed