Fix reflection based destructuring for redefined property #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RehanSaeed if you think this is good, please release a new version, I lost track of how to do that :-). |
domagojmedo
reviewed
May 17, 2021
|
@RehanSaeed can we merge this? |
|
Sorry, will take a look on Monday. |
Thanks, in the meantime I will start working on next PR based on this one 👍 |
RehanSaeed
reviewed
May 24, 2021
| private readonly Exception exception; | ||
| private readonly IExceptionPropertyFilter? filter; | ||
| private readonly Dictionary<string, object?> properties = new(); | ||
| private readonly Dictionary<string, object?> properties = new (); |
There was a problem hiding this comment.
Got some warings because:
The keyword 'new' should not be followed by a space
|
If you do not care I would rather merge this and then consider #347 separately. |
RehanSaeed
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I may prepare another fix to tackle the problem of gathering properties from a type taking into account possible redefinitions.
However, I consider the change proposed here good practice for library robustness.
Fixes #343