Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OperationCancelledException and TaskCancelledException #74

Merged
merged 21 commits into from
Nov 14, 2018

Conversation

krajek
Copy link
Collaborator

@krajek krajek commented Nov 4, 2018

Continuation of #65, closes #64

I will first cleanup style-cop warnings and tests, then add new tests and complete PR.
Work in progress.

@RehanSaeed
Copy link
Owner

wonderful

@krajek krajek self-assigned this Nov 11, 2018
@krajek krajek changed the title [WIP] Add support for OperationCancelledException and TaskCancelledException Add support for OperationCancelledException and TaskCancelledException Nov 11, 2018
@krajek
Copy link
Collaborator Author

krajek commented Nov 11, 2018

@Shatl and @RehanSaeed could you please take a last look on the PR?

Note, that I had to remove the usage of destructureException function for Task.Exception destructuring because it caused a stack overflow exception in case of cyclic references in the object graph. The reason is that destructuringObjects dictionary, that tracks already destructured objects was created once again for each new inner exception. Moreover, using destructureException would be incompatible with the rest of the reflection-based destructuring.

Copy link
Owner

@RehanSaeed RehanSaeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment, otherwise LGTM.

@krajek krajek merged commit 7f71c1a into RehanSaeed:master Nov 14, 2018
@krajek krajek deleted the alphacloud-feature/CancellationToken branch November 14, 2018 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not destructure CancellationToken
3 participants