Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata info protobuf format support #8

Merged
merged 30 commits into from
Aug 21, 2022
Merged
Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
48dbdfa
adding support to metadata info protobuf format
NRHelmi Jun 1, 2022
322f5cd
Revert "adding support to metadata info protobuf format"
NRHelmi Jun 1, 2022
1f8c2af
adding support to metadata info protobuf format
NRHelmi Jun 1, 2022
7aece42
cleanup
NRHelmi Jun 1, 2022
7736da4
proto update
NRHelmi Jun 3, 2022
8e72af3
sync with main
NRHelmi Jul 8, 2022
39671ce
Added get transaction protobuf metadata
NRHelmi Jul 10, 2022
2787e06
formatting
NRHelmi Aug 1, 2022
67cd7f7
cleanup
NRHelmi Aug 2, 2022
c3f5b6e
fix
NRHelmi Aug 2, 2022
6ffa664
fix metadata.pb path
NRHelmi Aug 2, 2022
cc9cf7e
fixing relation id in ExecAsync test
NRHelmi Aug 2, 2022
e40b36d
remove output type from Proto project
NRHelmi Aug 2, 2022
777560e
remove internal server proto file
NRHelmi Aug 2, 2022
843331b
support also osx
NRHelmi Aug 2, 2022
c962b9b
GetTransactionMetadataInfo to GetTransactionMetadata
NRHelmi Aug 2, 2022
8fcd9a3
adding metadata.pb.txt
NRHelmi Aug 3, 2022
e9eb94a
updated changelog && bump up version
NRHelmi Aug 3, 2022
5d7c492
sync with main
NRHelmi Aug 16, 2022
c7013e9
fix metadata proto test issue
NRHelmi Aug 17, 2022
bf38057
code formatting using dotnet format
NRHelmi Aug 18, 2022
d86d9aa
new lines added
NRHelmi Aug 18, 2022
78d2114
linter check added
NRHelmi Aug 18, 2022
3110eae
simulate bad written code
NRHelmi Aug 18, 2022
5acda8e
fix dotner command
NRHelmi Aug 18, 2022
a029ef5
fix lint issue
NRHelmi Aug 18, 2022
066c440
apply styling
NRHelmi Aug 19, 2022
fad0ad5
sync with main
NRHelmi Aug 19, 2022
d8fe19c
fix linting
NRHelmi Aug 19, 2022
32a7203
fix test
NRHelmi Aug 19, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ RelationalAI.Test/bin
RelationalAI.Test/obj
RelationalAI.Examples/bin
RelationalAI.Examples/obj
RelationalAI.Protos/bin
RelationalAI.Protos/obj
RelationalAI/bin
RelationalAI/obj
launch.json
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## v0.6.0-alpha
* Deprecated metadata json format.
* Removed `TransactionAsyncMetadataResponse` model.
* Added support to metadata protobuf format.
* `GetTransactionMetadata` returns protobuf metadata.

## v0.5.0-alpha
* In this update we ensure the SDK follows the standard async/await approach for the methods. The following methods have been renamed to include the "Async" postfix, made async and now return a `Task<T>` to the user:
- `CreateDatabase`, `GetDatabase`, `ListDatabases`, `DeleteDatabase`, `CloneDatabase`.
Expand Down
12 changes: 5 additions & 7 deletions RelationalAI.Examples/GetTransactionMetadata.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Collections.Generic;
using System.CommandLine;
using System.CommandLine.NamingConventionBinder;
Expand All @@ -21,7 +21,7 @@ public static Command GetCommand()
Description = "Profile name from .rai/config to connect to RAI Cloud."
}
};
cmd.Description = "Get an asynchronous transaction metadata.";
cmd.Description = "Get an asynchronous transaction protobuf metadata.";
cmd.Handler = CommandHandler.Create<string, string>(Run);
return cmd;
}
Expand All @@ -31,11 +31,9 @@ private static async Task Run(string id, string profile = "default")
Dictionary<string, object> config = Config.Read("", profile);
Client.Context context = new Client.Context(config);
Client client = new Client(context);
var metadataList = await client.GetTransactionMetadataAsync(id);
foreach(var metadata in metadataList)
{
Console.WriteLine(metadata);
}

var metadata = await client.GetTransactionMetadataAsync(id);
Console.WriteLine(metadata);
}
}
}
Loading