Bugfix checksum validation in rem.utils #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the bug was when the hex character of the address hash value == 8, it was taken tolower
Alladin9393
force-pushed
the
bugfix_rem_utils_checksum_validation
branch
from
418cd04 to
f9c4376
Compare
Art17
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
The bug was when the hex character of the address hash value was equal 8, it was taken to lower, but should be to upper.
This was due to outdated documentation EIP-55.
Latest Documentation EIP-55.
Consensus Changes
API Changes
Documentation Additions