Add support for user-installable applications #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue was I didn't update the remaining samples. Fixing that has shown me that I have other things I need to add and fix. |
|
Please rebase this onto the latest commit so you get all the required ReSharper inspection checks. |
This may be non-functional at time of commit!
N.B: It is important to note that Remora allows: - Automatic framework responses - Those responses to be made ephemeral Because of this, it brings into question whether there should be validation on the account that a command may be marked as ephemeral, (or worse, may be marked as NON-ephemeral) when the callback hint would indicate that the opposite is true. This behavior- or lack thereof- is technically spawned from developer error, despite being the framework's decision on how to handle commands.
BREAKING-CHANGE: This changes the constructor of the `AllowedContextsAttribute` to take a `params ApplicationCommandContextType[]` instead of an `IReadOnlyList`
This commit is broken, as the Remora.Rest dependency needs to be updated to the latest version to fix one (1) test.
VelvetToroyashi
force-pushed
the
feat/user-apps
branch
from
3dd6934 to
9736b65
Compare
|
Well, messed up my commit dates, but at least it's rebased now. :v |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
InspectCode found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
You might want to add the |
Nihlus
requested changes
Apr 4, 2024
Backend/Remora.Discord.API.Abstractions/API/Objects/Applications/ApplicationIntegrationType.cs
Show resolved
Hide resolved
Backend/Remora.Discord.API.Abstractions/API/Objects/Interactions/IInteraction.cs
Show resolved
Hide resolved
Backend/Remora.Discord.API.Abstractions/API/Objects/Interactions/IMessageInteractionMetadata.cs
Show resolved
Hide resolved
Backend/Remora.Discord.API/Extensions/ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
Backend/Remora.Discord.Rest/API/Applications/DiscordRestApplicationAPI.cs
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.