-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Zend_Dom dependency #23
Comments
We have to improve their packaging and contribute with them. |
This was fixed with 3fd1193 It now requires brikou/zend_dom which gets installed properly with composer. @henriquemoody I suppose you can delete the library\Zend folder now as it is not required anymore since the Zend\Dom namespace is appropriately linked with composer to brikou/zend_dom. see: vendor/composer/autoload_namespaces.php
. |
Guys, I did not see this commit 7f50f74 |
The patch adds the Zend library to the autoloader_namespace
In case we still want to keep the Zend library packaged. Hope that makes sense. I cannot vouch for any pear dependencies etc but this was not working with composer before and this is what I did to fix it. See #25 |
Today we depend on Zend_Dom to translate CSS selectors into XPATH selectors, that's cool. What is not cool is that (as of today) Zend_Dom is not compatible to pear anymore. We have to support as many package managers we can, until we comehow know how to fix this support, this issue will remain open.
The text was updated successfully, but these errors were encountered: