Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat audio mixing in a single place #23

Closed
hrosa opened this issue Jul 6, 2015 · 0 comments
Closed

Treat audio mixing in a single place #23

hrosa opened this issue Jul 6, 2015 · 0 comments
Assignees
@hrosa
Labels
enhancement

Comments

@hrosa
Copy link
Contributor

hrosa commented Jul 6, 2015

At the moment, the audio mixing elements are scattered over different classes, in different hierarchy levels: Endpoint, Connection, Channels, etc.

I propose moving the mixing element to a single well-contained class, located between the endpoint and its connections.

This will allow us to expand the endpoints to choose between RTP relay type (mixer or translator) very easily.
hrosa added a commit that referenced this issue Jul 6, 2015
@hrosa
#23 Added notion of relay type to the endpoint.
f8b70cd
hrosa added a commit that referenced this issue Jul 6, 2015
@hrosa
#23 Connections now expose their mixing components to a higher layer.…
1e8aba9 
… Missing implementation details.
hrosa added a commit that referenced this issue Jul 6, 2015
@hrosa
#23 Creating middle box for RTP mixing components.
c1290f6 
Refactoring RtpInput and RtpOutput.
hrosa added a commit that referenced this issue Jul 7, 2015
@hrosa
#23 Refactoring DtmfInput and DtmfOutput
60c0d2b
hrosa added a commit that referenced this issue Jul 7, 2015
@hrosa
#23 Wired RTP input and output to the RTP mixer component.
d49124a 
Created class diagram for new architecture.
hrosa added a commit that referenced this issue Jul 8, 2015
@hrosa
#23 Wired RTP Mixer Component to the Media Channel for RTP transport.…
0b754b4 
… Need to refactor MediaChannel for intended behaviour.
hrosa added a commit that referenced this issue Jul 8, 2015
@hrosa
#23 Renamed RtpChannel to RtpTransport.
2f448c1 
Renamed MediaChannel to RtpChannel.

Updated class diagram to include relationship between RtpConnection and its media channels.
hrosa added a commit that referenced this issue Jul 8, 2015
@hrosa
#23 Renamed RtcpChannel to RtcpTransport.
4a2b2a4
@hrosa hrosa mentioned this issue Jul 8, 2015
Open
hrosa added a commit that referenced this issue Jul 8, 2015
@hrosa
#23 Started decoupling mixer components from RTP channel.
f8d8f4f 
RtpHandler now forwards incoming RTP packets to the RTP gateway, where it is decided if it is mixed or forwarded.
hrosa added a commit that referenced this issue Jul 9, 2015
@hrosa
#23 Finished integrating the RTP handler with the RTP gateway, comple…
d389504 
…tely decoupling it from the media mixer components.
@hrosa hrosa self-assigned this Jul 9, 2015
hrosa added a commit that referenced this issue Jul 10, 2015
@hrosa
#23 Wired the mixer component to the RTP channel for sending outgoing…
297b667 
… traffic. RtpTransmitter is now deprecated.
hrosa added a commit that referenced this issue Jul 13, 2015
@hrosa
#23 Continued refactoring.
ffa01f1 
Updated RTP classes diagram.

Fixing test suite.
hrosa added a commit that referenced this issue Jul 14, 2015
@hrosa
#23 The RTP mixer is now responsible for overwriting the sequence num…
17c5207 
…ber and SSRC fields of the outgoing RTP packets.

Added method in RTP packet to overwrite the SSRC and sequence number fields directly in the byte buffer. Added case to testsuite.
hrosa added a commit that referenced this issue Jul 14, 2015
@hrosa
#23 Wired the RTP mixer component to the RTP channel.
70d5dbc
hrosa added a commit that referenced this issue Jul 14, 2015
@hrosa
#23 Removed unnecessary RTP formats from RtpTransport.
8493620
hrosa added a commit that referenced this issue Jul 14, 2015
@hrosa
#23 Renamed RtpConnectionImpl to RtpConnection
065471d
hrosa added a commit that referenced this issue Jul 15, 2015
@hrosa
#23 ChannelsManager now contains a DSP Factory, used in the productio…
0dea334 
…n of media channels.

ChannelsManager no longer produces RtpTransport objects.

Wiring the RTP channel to the RTP relay interface (media mixer).

Fixing test suite.
hrosa added a commit that referenced this issue Jul 15, 2015
@hrosa
#23 Wired the RtpRelay to the RtpTransport.
de48bde 
Fixing the testsuite.

Updated class diagram.
hrosa added a commit that referenced this issue Jul 16, 2015
@hrosa
#23 Refatored mixer endpoint to include new mixer components. The com…
4bed510 
…ponents are registered in the media mixer when a connection is created and released when the connection is deleted.

Updated class diagram for RTP and mixer elements.
hrosa added a commit that referenced this issue Jul 16, 2015
@hrosa
#23 the RTP relay (mixer component) is now aware of possible IO opera…
bc17502 
…tions, based on the current connection mode.
hrosa added a commit that referenced this issue Jul 16, 2015
@hrosa
#23 Using boolean flag to control the integrity of start/stop operati…
34707ef 
…ons in the Audio Mixer
hrosa added a commit that referenced this issue Jul 20, 2015
@hrosa
#23 Audio mixing is now working well in SEND_ONLY, RECV_ONLY and SEND…
53a8e5b 
…_RECV modes. The RtpTransportTest is now passing.
@mcacker mcacker mentioned this issue Jul 20, 2015
Open
hrosa added a commit that referenced this issue Jul 20, 2015
@hrosa
#23 The mixCount of the Audio Mixer is now private and accessible onl…
b64e5d6 
…y via getter. Converted some properties of the Audio Mixer into static constants. Applied formating to Audio Mixer.
hrosa added a commit that referenced this issue Jul 20, 2015
@hrosa
#23 Renamed MixerComponent to MediaComponent so it can also be used b…
4f04ab8 
…y a MediaSplitter.

Refactored the Splitter endpoint to rely on MediaComponent objects.
hrosa added a commit that referenced this issue Jul 20, 2015
@hrosa
#23 Refactored the LocalConnection and LocalDataChannel to rely on th…
1de9ffc 
…e MediaComponent. Fixed test suite for local connections.
hrosa added a commit that referenced this issue Jul 21, 2015
@hrosa
#23 Fixed test suite, all tests are passing.
8df5649
hrosa added a commit that referenced this issue Jul 21, 2015
@hrosa
#23 Fixed issue related with pooled connections when using ICE where …
c05ce80 
…the RTP channel is never connected to the remote peer.
hrosa added a commit that referenced this issue Jul 21, 2015
@hrosa
#23 Updated the class diagram to reflect how the RTP statistics must …
4b87c9b 
…be wired to the RTP relay (mixer component or translator)
hrosa added a commit that referenced this issue Jul 22, 2015
@hrosa
#23 Updated the class diagram to include the RtpStatistics.
3fba882 
Wired the new mixer components to the SS7 Endpoint.
@hrosa hrosa closed this as completed Jul 22, 2015
hrosa added a commit that referenced this issue Jul 29, 2015
@hrosa
#23 Created generic AbstractRelayEndpoint that concrete endpoint impl…
ac2072f 
…ementation must extend. Deprecates BaseMixerEndpoint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hrosa hrosa

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hrosa