Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gennodejs name-switch #6

Merged
merged 5 commits into from
Apr 26, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.rst
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
^^^^^^^^^^^^^^^^^^^^^^^^^^^
Changelog for package genjs
Changelog for package gennodejs
^^^^^^^^^^^^^^^^^^^^^^^^^^^

1.0.0 (2016-4-19)
Expand Down
14 changes: 7 additions & 7 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
cmake_minimum_required(VERSION 2.8.3)
project(genjs)
project(gennodejs)
find_package(catkin REQUIRED COMPONENTS genmsg)

catkin_package(
CATKIN_DEPENDS genmsg
CFG_EXTRAS genjs-extras.cmake
CFG_EXTRAS gennodejs-extras.cmake
)

add_subdirectory(scripts)

file(WRITE ${CATKIN_DEVEL_PREFIX}/${GENMSG_LANGS_DESTINATION}/genjs "JAVASCRIPT")
install(FILES ${CATKIN_DEVEL_PREFIX}/${GENMSG_LANGS_DESTINATION}/genjs
file(WRITE ${CATKIN_DEVEL_PREFIX}/${GENMSG_LANGS_DESTINATION}/gennodejs "JAVASCRIPT")
install(FILES ${CATKIN_DEVEL_PREFIX}/${GENMSG_LANGS_DESTINATION}/gennodejs
DESTINATION ${GENMSG_LANGS_DESTINATION})

# install base serialization, deserialization files
set(base_files
src/genjs/base_serialize.js
src/genjs/base_deserialize.js
src/genjs/find.js)
src/gennodejs/base_serialize.js
src/gennodejs/base_deserialize.js
src/gennodejs/find.js)

file(COPY ${base_files} DESTINATION ${CATKIN_DEVEL_PREFIX}/share/node_js)
install(FILES ${base_files}
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1 +1 @@
# genjs
# gennodejs
49 changes: 0 additions & 49 deletions cmake/genjs-extras.cmake.em

This file was deleted.

49 changes: 49 additions & 0 deletions cmake/gennodejs-extras.cmake.em
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
@[if DEVELSPACE]@
# bin variable in develspace
set(GENNODEJS_BIN "@(CMAKE_CURRENT_SOURCE_DIR)/scripts/gen_nodejs.py")
@[else]@
# bin variable in installspace
set(GENNODEJS_BIN "${gennodejs_DIR}/../../../@(CATKIN_PACKAGE_BIN_DESTINATION)/gen_nodejs.py")
@[end if]@

# Generate .msg or .srv -> .js
# The generated .js files should be added ALL_GEN_OUTPUT_FILES_js
macro(_generate_nodejs ARG_PKG ARG_MSG ARG_IFLAGS ARG_MSG_DEPS ARG_GEN_OUTPUT_DIR)
file(MAKE_DIRECTORY ${ARG_GEN_OUTPUT_DIR})

#Create input and output filenames
get_filename_component(MSG_NAME ${ARG_MSG} NAME)
get_filename_component(MSG_SHORT_NAME ${ARG_MSG} NAME_WE)

set(MSG_GENERATED_NAME ${MSG_SHORT_NAME}.js)
set(GEN_OUTPUT_FILE ${ARG_GEN_OUTPUT_DIR}/${MSG_GENERATED_NAME})

assert(CATKIN_ENV)
add_custom_command(OUTPUT ${GEN_OUTPUT_FILE}
DEPENDS ${GENNODEJS_BIN} ${ARG_MSG} ${ARG_MSG_DEPS}
COMMAND ${CATKIN_ENV} ${PYTHON_EXECUTABLE} ${GENNODEJS_BIN} ${ARG_MSG}
${ARG_IFLAGS}
-p ${ARG_PKG}
-o ${ARG_GEN_OUTPUT_DIR}
COMMENT "Generating Javascript code from ${ARG_PKG}/${MSG_NAME}"
)

list(APPEND ALL_GEN_OUTPUT_FILES_nodejs ${GEN_OUTPUT_FILE})

endmacro()

#gennodejs uses the same program to generate srv and msg files, so call the same macro
macro(_generate_msg_nodejs ARG_PKG ARG_MSG ARG_IFLAGS ARG_MSG_DEPS ARG_GEN_OUTPUT_DIR)
_generate_nodejs(${ARG_PKG} ${ARG_MSG} "${ARG_IFLAGS}" "${ARG_MSG_DEPS}" "${ARG_GEN_OUTPUT_DIR}/msg")
endmacro()

#gennodejs uses the same program to generate srv and msg files, so call the same macro
macro(_generate_srv_nodejs ARG_PKG ARG_SRV ARG_IFLAGS ARG_MSG_DEPS ARG_GEN_OUTPUT_DIR)
_generate_nodejs(${ARG_PKG} ${ARG_SRV} "${ARG_IFLAGS}" "${ARG_MSG_DEPS}" "${ARG_GEN_OUTPUT_DIR}/srv")
endmacro()

macro(_generate_module_nodejs ARG_PKG ARG_GEN_OUTPUT_DIR ARG_GENERATED_FILES)
endmacro()

set(node_js_INSTALL_DIR share/node_js)
set(gennodejs_INSTALL_DIR ${node_js_INSTALL_DIR}/ros)
2 changes: 1 addition & 1 deletion package.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0"?>
<package>
<name>genjs</name>
<name>gennodejs</name>
<version>1.0.0</version>
<description>
Javascript ROS message and service generators.
Expand Down
2 changes: 1 addition & 1 deletion scripts/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
catkin_install_python(
PROGRAMS gen_js.py
PROGRAMS gen_nodejs.py
DESTINATION ${CATKIN_PACKAGE_BIN_DESTINATION})
4 changes: 2 additions & 2 deletions scripts/gen_js.py → scripts/gen_nodejs.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
##
## Converts ROS .msg files in a package into JS source files

import genjs
import gennodejs
import sys

if __name__ == "__main__":
genjs.genjs_main.genmain(sys.argv, 'gen_js.py')
gennodejs.gennodejs_main.genmain(sys.argv, 'gen_nodejs.py')
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from catkin_pkg.python_setup import generate_distutils_setup

d = generate_distutils_setup(
packages=['genjs'],
packages=['gennodejs'],
package_dir={'': 'src'},
requires=['genmsg']
)
Expand Down
2 changes: 1 addition & 1 deletion src/genjs/__init__.py → src/gennodejs/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
from . genjs_main import *
from . gennodejs_main import *
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.