Fix testCheats when running standalone #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolved the conflict. |
Flamefire
force-pushed
the
cheat-test
branch
4 times, most recently
from
1e09468 to
c521bd9
Compare
The test creates a desktop instance that requires access to the VideoDriver and potentially resources (graphics) which are not available at this point. This leads to failures when the test is not started after a test installing a test-videodriver in the same process. Manually create the required instances without that desktop.
Avoid conflicts and polution
They might contain stale objects leading to ``` /usr/bin/ld: CMakeFiles/s25client.dir/s25client.cpp.o: in function `(anonymous namespace)::handleException(void*) [clone .constprop.0]': s25client.cpp:(.text+0x18b2): undefined reference to `DebugInfo::SendStackTrace(std::vector<void*, std::allocator<void*> > const&)' ```
Flamefire
force-pushed
the
cheat-test
branch
from
c521bd9 to
0e1a995
Compare
|
@Flow86 Again having the issue with undefined references to symbols removed earlier. Not sure why this keeps popping up. I added a commit to make it at least use architecture dependent folders as maybe it was mixing up the builds |
Flow86
approved these changes
Feb 25, 2025
Flow86
reviewed
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test creates a desktop instance that requires access to the VideoDriver and potentially resources (graphics) which are not available at this point. This leads to failures when the test is not started after a test installing a test-videodriver in the same process.
Manually create the required instances without that desktop.