Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix needs with nested namespaces (fix #1188) #1189

Closed
wants to merge 2 commits into from

Conversation

ferki
Copy link
Member

@ferki ferki commented Jan 19, 2018

This PR fixes #1188 by converting any Perl module namespace separators into Rex task namespace separators.

@alip: could you try this and see if it solves your use case, please? I'm considering to include this in 1.6.0 as a last minute patch, so I thought some extra feedback would be nice :)

@ferki ferki added the in progress A topic that is currently being taken care of label Jan 19, 2018
@ferki ferki added this to the 1.6.0 milestone Jan 19, 2018
@alip
Copy link
Contributor

alip commented Jan 22, 2018

@ferki: Thanks! I'll test as soon as I can and report back.

@ferki ferki force-pushed the needs_namespaces branch from 96319e4 to 88949fd Compare April 21, 2018 20:33
@ferki ferki modified the milestones: 1.6.0, 1.6.1 Apr 21, 2018
@ferki
Copy link
Member Author

ferki commented Apr 29, 2018

Merged into master branch.

@ferki ferki closed this Apr 29, 2018
@ferki ferki removed the in progress A topic that is currently being taken care of label Apr 29, 2018
@ferki ferki modified the milestones: 1.6.1, 1.7.0 Jun 20, 2018
@ehuelsmann ehuelsmann deleted the needs_namespaces branch July 26, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants