Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove share resource #564

Merged
merged 1 commit into from
May 5, 2024
Merged

Remove share resource #564

merged 1 commit into from
May 5, 2024

Conversation

M-Adoo
Copy link
Collaborator

@M-Adoo M-Adoo commented Apr 25, 2024

Purpose of this Pull Request

Clarify the usage of resources across painters, widgets, and wgpu rendering.

Checklist Before Merging

Please ensure the following are completed before merging:

  • If this is linked to an issue, include the link in your description.
  • If you've made changes to the code or documentation, make sure these are updated in the CHANGELOG.md file.
  • If you've introduced any break changes, briefly describe them in the Breaking section of the CHANGELOG.md file.

Additional Information

The bot will replace #pr in CHANGELOG.md with your pull request number. If your branch is out of sync, use git pull --rebase to update it.

If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.

If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.

@github-actions github-actions bot force-pushed the remove-share-resource branch from 483bfec to 702a297 Compare April 25, 2024 12:48
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Apr 25, 2024
@M-Adoo M-Adoo force-pushed the remove-share-resource branch from 702a297 to aa266e2 Compare May 4, 2024 03:18
@M-Adoo M-Adoo marked this pull request as ready for review May 4, 2024 03:19
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label May 4, 2024
@github-actions github-actions bot force-pushed the remove-share-resource branch from aa266e2 to 02f5951 Compare May 4, 2024 03:19
@M-Adoo M-Adoo enabled auto-merge May 4, 2024 03:19
@M-Adoo M-Adoo added the B-test Notify bot to start testing label May 4, 2024
@M-Adoo M-Adoo force-pushed the remove-share-resource branch from 02f5951 to 819b8d4 Compare May 5, 2024 06:51
@M-Adoo M-Adoo added B-test Notify bot to start testing and removed B-test Notify bot to start testing labels May 5, 2024
@M-Adoo M-Adoo requested review from wjian23 and sologeek May 5, 2024 06:51
@M-Adoo M-Adoo added this pull request to the merge queue May 5, 2024
Merged via the queue into master with commit cb5b86b May 5, 2024
13 checks passed
@M-Adoo M-Adoo deleted the remove-share-resource branch May 5, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-test Notify bot to start testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants