Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/webgl support #578

Merged
merged 6 commits into from
May 20, 2024
Merged

Feat/webgl support #578

merged 6 commits into from
May 20, 2024

Conversation

M-Adoo
Copy link
Collaborator

@M-Adoo M-Adoo commented May 15, 2024

Purpose of this Pull Request

Updated the wgpu implementation of the GPU backend to support WebGL.

If we manually disable AntiAliasing in the code, Ribir will work as expected on WebGL.
I will soon create a new pull request to refactor the anti-aliasing feature.

image

Checklist Before Merging

Please ensure the following are completed before merging:

  • If this is linked to an issue, include the link in your description.
  • If you've made changes to the code or documentation, make sure these are updated in the CHANGELOG.md file.
  • If you've introduced any break changes, briefly describe them in the Breaking section of the CHANGELOG.md file.

Additional Information

The bot will replace #pr in CHANGELOG.md with your pull request number. If your branch is out of sync, use git pull --rebase to update it.

If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.

If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.

@M-Adoo M-Adoo enabled auto-merge May 15, 2024 10:29
@M-Adoo M-Adoo requested review from wjian23 and sologeek May 15, 2024 10:29
@M-Adoo M-Adoo force-pushed the feat/webgl-support branch from 1bf85f3 to 3c89c44 Compare May 15, 2024 12:35
@github-actions github-actions bot force-pushed the feat/webgl-support branch from 3c89c44 to 07ee2e9 Compare May 15, 2024 12:35
@M-Adoo M-Adoo added the B-test Notify bot to start testing label May 15, 2024
@M-Adoo M-Adoo added this to the 0.3 milestone May 15, 2024
@M-Adoo M-Adoo added B-test Notify bot to start testing and removed B-test Notify bot to start testing labels May 15, 2024
@M-Adoo M-Adoo disabled auto-merge May 15, 2024 14:02
@M-Adoo M-Adoo enabled auto-merge May 16, 2024 07:20
@M-Adoo M-Adoo force-pushed the feat/webgl-support branch from b975d83 to 0688e9a Compare May 16, 2024 09:01
@M-Adoo M-Adoo added B-test Notify bot to start testing and removed B-test Notify bot to start testing labels May 16, 2024
@M-Adoo M-Adoo disabled auto-merge May 16, 2024 11:54
@M-Adoo M-Adoo force-pushed the feat/webgl-support branch from 0688e9a to 994a440 Compare May 17, 2024 16:13
@M-Adoo M-Adoo added B-test Notify bot to start testing and removed B-test Notify bot to start testing labels May 17, 2024
@M-Adoo M-Adoo enabled auto-merge May 17, 2024 16:14
@M-Adoo M-Adoo force-pushed the feat/webgl-support branch from 994a440 to e704e7c Compare May 17, 2024 17:08
@M-Adoo M-Adoo added B-test Notify bot to start testing and removed B-test Notify bot to start testing labels May 17, 2024
@M-Adoo M-Adoo force-pushed the feat/webgl-support branch from e704e7c to 499051c Compare May 17, 2024 17:09
@M-Adoo M-Adoo added B-test Notify bot to start testing and removed B-test Notify bot to start testing labels May 17, 2024
@M-Adoo M-Adoo added this pull request to the merge queue May 20, 2024
Merged via the queue into RibirX:master with commit b5d5841 May 20, 2024
13 checks passed
@M-Adoo M-Adoo deleted the feat/webgl-support branch May 20, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-test Notify bot to start testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants