-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/webgl support #578
Merged
Merged
Feat/webgl support #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-Adoo
force-pushed
the
feat/webgl-support
branch
from
May 15, 2024 12:35
1bf85f3
to
3c89c44
Compare
github-actions
bot
force-pushed
the
feat/webgl-support
branch
from
May 15, 2024 12:35
3c89c44
to
07ee2e9
Compare
2 tasks
M-Adoo
added
B-test
Notify bot to start testing
and removed
B-test
Notify bot to start testing
labels
May 15, 2024
M-Adoo
force-pushed
the
feat/webgl-support
branch
from
May 16, 2024 09:01
b975d83
to
0688e9a
Compare
M-Adoo
added
B-test
Notify bot to start testing
and removed
B-test
Notify bot to start testing
labels
May 16, 2024
M-Adoo
force-pushed
the
feat/webgl-support
branch
from
May 17, 2024 16:13
0688e9a
to
994a440
Compare
M-Adoo
added
B-test
Notify bot to start testing
and removed
B-test
Notify bot to start testing
labels
May 17, 2024
M-Adoo
force-pushed
the
feat/webgl-support
branch
from
May 17, 2024 17:08
994a440
to
e704e7c
Compare
M-Adoo
added
B-test
Notify bot to start testing
and removed
B-test
Notify bot to start testing
labels
May 17, 2024
…orrect configuration
M-Adoo
force-pushed
the
feat/webgl-support
branch
from
May 17, 2024 17:09
e704e7c
to
499051c
Compare
M-Adoo
added
B-test
Notify bot to start testing
and removed
B-test
Notify bot to start testing
labels
May 17, 2024
sologeek
approved these changes
May 20, 2024
wjian23
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this Pull Request
Updated the
wgpu
implementation of the GPU backend to support WebGL.If we manually disable AntiAliasing in the code, Ribir will work as expected on WebGL.
I will soon create a new pull request to refactor the anti-aliasing feature.
Checklist Before Merging
Please ensure the following are completed before merging:
CHANGELOG.md
file.Breaking
section of theCHANGELOG.md
file.Additional Information
The bot will replace
#pr
inCHANGELOG.md
with your pull request number. If your branch is out of sync, usegit pull --rebase
to update it.If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.
If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.