Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Provide #688

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Improve Provide #688

merged 5 commits into from
Jan 9, 2025

Conversation

M-Adoo
Copy link
Collaborator

@M-Adoo M-Adoo commented Jan 8, 2025

Purpose of this Pull Request

Refactor the provider to:

  1. Ensure it is accessible in all contexts.
  2. Optimize provider retrieval to O(1) complexity.
  3. Enhance usability to be similar to a regular widget.
  4. Enhance the documentation for better understanding.

Checklist Before Merging

Please ensure the following are completed before merging:

  • If this is linked to an issue, include the link in your description.
  • If you've made changes to the code or documentation, make sure these are updated in the CHANGELOG.md file.
  • If you've introduced any break changes, briefly describe them in the Breaking section of the CHANGELOG.md file.

Additional Information

The bot will replace #pr in CHANGELOG.md with your pull request number. If your branch is out of sync, use git pull --rebase to update it.

If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.

If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.

@github-actions github-actions bot force-pushed the feat/build-variant branch from 19b6bf0 to baa463d Compare January 8, 2025 09:56
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Jan 8, 2025
@M-Adoo M-Adoo force-pushed the feat/build-variant branch from baa463d to 2a41e5b Compare January 8, 2025 12:11
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Jan 8, 2025
@github-actions github-actions bot force-pushed the feat/build-variant branch from 2a41e5b to c0097a8 Compare January 8, 2025 12:11
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Jan 8, 2025
@M-Adoo M-Adoo force-pushed the feat/build-variant branch from c0097a8 to 830c296 Compare January 8, 2025 12:18
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Jan 8, 2025
@github-actions github-actions bot force-pushed the feat/build-variant branch from 830c296 to ba37b99 Compare January 8, 2025 12:18
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Jan 8, 2025
@M-Adoo M-Adoo marked this pull request as ready for review January 8, 2025 12:22
@M-Adoo M-Adoo enabled auto-merge January 8, 2025 12:22
@M-Adoo M-Adoo changed the title Feat/build variant Improve Provide Jan 8, 2025
@M-Adoo M-Adoo added this pull request to the merge queue Jan 9, 2025
Merged via the queue into RibirX:master with commit 8d490cb Jan 9, 2025
14 checks passed
@M-Adoo M-Adoo deleted the feat/build-variant branch January 9, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-test Notify bot to start testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants