Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add brackets for assignment expression if its a body of an arrow function #70

Merged
merged 4 commits into from
Jan 6, 2022
Merged

add brackets for assignment expression if its a body of an arrow function #70

merged 4 commits into from
Jan 6, 2022

Conversation

sahilmob
Copy link
Contributor

@sahilmob sahilmob commented Jan 2, 2022 •
edited by Conduitry
Loading

@Conduitry
Copy link
Collaborator

Thanks!

I think we'd like to only do this when the left-hand side of the assignment is an ObjectPattern. Could you make that change and add a test please?

@sahilmob
Copy link
Contributor Author

sahilmob commented Jan 6, 2022

Changes are ready!

@Conduitry Conduitry merged commit 93f852c into Rich-Harris:master Jan 6, 2022
@Conduitry
Copy link
Collaborator

Thank you! Made a couple of tweaks and released as 0.2.4.

@Conduitry Conduitry mentioned this pull request Jan 6, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sahilmob @Conduitry