Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addObserver issue fix: using context rather than activity in LocationServices #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

addObserver issue fix: using context rather than activity in LocationServices #71

wants to merge 1 commit into from
+4 −2

Conversation

vivekvardhanadepu
Copy link

fixes #67

@vivekvardhanadepu vivekvardhanadepu mentioned this pull request Dec 15, 2021
Open
@vatsal-gadhiya-searce
Copy link

@Richou Can we merge this please?

@anees17861
Copy link

@vivekvardhanadepu This doesn't address the actual issue properly. As suggested in the error, it needs to be called in main thread.
Instead of using reactContext try surrounding the location api with

new Handler(Looper.getMainLooper()).post(() -> {

})

This should make the call on main thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Method addObserver must be called on the main thread
3 participants
@vivekvardhanadepu @vatsal-gadhiya-searce @anees17861