Fix unwanted query parameter explosion in generated c# client #4310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this doesn't fix the OpenApi 2.0 variant: |
paulcurren
reviewed
Jan 13, 2023
| @@ -6,8 +6,13 @@ foreach (var item_ in {{ parameter.VariableName }}) { urlBuilder_.Append(System. | |||
| urlBuilder_.Append(System.Uri.EscapeDataString("{{ parameter.Name }}") + "=").Append(System.Uri.EscapeDataString({% if parameter.IsNullable and parameter.IsRequired %}{{ parameter.VariableName }} != null ? {% endif %}{{ parameter.VariableName }}{% if parameter.IsSystemNullable %}.Value{% endif %}.ToString("{{ ParameterDateTimeFormat }}", System.Globalization.CultureInfo.InvariantCulture){% if parameter.IsNullable and parameter.IsRequired %} : "{{ QueryNullValue }}"{% endif %})).Append("&"); | |||
| {% elsif parameter.IsDate -%} | |||
| urlBuilder_.Append(System.Uri.EscapeDataString("{{ parameter.Name }}") + "=").Append(System.Uri.EscapeDataString({% if parameter.IsNullable and parameter.IsRequired %}{{ parameter.VariableName }} != null ? {% endif %}{{ parameter.VariableName }}{% if parameter.IsSystemNullable %}.Value{% endif %}.ToString("{{ ParameterDateFormat }}", System.Globalization.CultureInfo.InvariantCulture){% if parameter.IsNullable and parameter.IsRequired %} : "{{ QueryNullValue }}"{% endif %})).Append("&"); | |||
| {% elsif parameter.IsArray -%} | |||
| {% elsif parameter.IsArray and parameter.Explode == true -%} | |||
There was a problem hiding this comment.
Should also test for "collectionFormat": "csv",
|
Hey, can this pull request be considered for merging in near future? This bug is already quite old and it is an easy fix. |
|
Hey, are any changes needed for this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per default NSwag ignores if array parameters should be exploded or not.
So as of now a request containing multiple IDs generates the following:
/users?id=3&id=4&id=5As per specification we do not want to specify the parameter name every time in case
explodeis set to false.Instead we expect
/users?id=3,4,5.