-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-file output to NSwagStudio #4472
Open
TheCakeMonster
wants to merge
44
commits into
RicoSuter:master
Choose a base branch
from
panoramicdata:newGenerateFilesMethod
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add multi-file output to NSwagStudio #4472
TheCakeMonster
wants to merge
44
commits into
RicoSuter:master
from
panoramicdata:newGenerateFilesMethod
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eferences to netcoreapp2.1 and net5.0.
…entFiles and GenerateDTO files
…les. Added missing XML comments to new methods in ClientGeneratorBase
…lientGeneratorSettings.
Rename of variables to aid readability Rename of tests to clarify what is tested
…tifact that it is intended to represent
…d implemented that into the GenerateFiles method
…eneration style is SingleFile
…rType now works, provided the file selected in NSwagStudio has a one letter name.
…dios now generates all files.
…which interfaces they're used in.
Split path based on separator, not length
…ypassed if contracts are generated
…he CodeArtifactType Interface. Removed unnecessary folder sorting method in OpenApiToCSharpClientCommand.
…iew to PropertyChanged
soroshsabz
suggested changes
Jul 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR could not merge before #4227
Any chance it'll merged? |
@Bykiev I think it needs a rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for splitting the generated output into multiple, separate files. Tested (and in use) for C#; whether this additionally supports other languages has not been tested.
This is built upon PR #4227, which was required so that we were not required to install unsupported runtimes on our machines. Therefore, it includes dropping support for .NET Core 2.1 and 3.0, and .NET 5.0, as well as bumping the minimum supported version of .NET Framework to .NET 4.6.2
Credit for this change goes to @geckogeckogecko who did all of the detailed work while at PDL.
Addresses the epic #1398