Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RZBaseSwipeInteractionController short circuits interactive transitions #46

Closed
bskinner opened this issue Feb 3, 2016 · 1 comment
Closed

RZBaseSwipeInteractionController short circuits interactive transitions #46

bskinner opened this issue Feb 3, 2016 · 1 comment

Comments

@bskinner
Copy link
Contributor

bskinner commented Feb 3, 2016

#29 introduces an issue which breaks interactive transitions backed by the RZBaseSwipeInteractionController. The transition is canceled before the gesture actually ends which prevents normal completion behaviors from taking place.
@bskinner bskinner self-assigned this Feb 3, 2016
bskinner pushed a commit that referenced this issue Feb 3, 2016
Transition should not be immediately canceled after the gesture begins …
47b4a67 
…#46
bskinner pushed a commit that referenced this issue Feb 3, 2016
Animation cleanup #46
c7c1026 
- The masking CALayer should be removed after the animation ends
- `super`'s `animateTransiton:` method should be called at the beginning of the method body, otherwise the from and to views are not laid out.
@bskinner bskinner removed their assignment Feb 3, 2016
@bskinner
Copy link
Contributor Author

bskinner commented Feb 3, 2016

@dostrander I just submitted #47 which should fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bskinner