Fix #322

NEWS.md

@@ -5,14 +5,15 @@
 [pagination](https://getbootstrap.com/docs/4.0/components/pagination/).
 
 ## Bug fixes
-- Fix #306: Dynamic menuSubItems with apply() adds some extra text. Added __.list__
-param to `menuItem()` to programatically pass `menuSubItem()` as list. 
+- Fix #322: `notificationItem()` href does not work. 
+- Fix #306: Dynamic `menuSubItems()` with apply() adds some extra text. Added __.list__
+param to `menuItem()` to programmatically pass `menuSubItem()` as list. 
 - Fix #297: `tabsetPanel()` renders below the list of `tabPanels` when vertical = TRUE. 
 Changed layout to `fluidRow`. Thanks @lucas-alcantara for reporting. 
 - Fix #296: Documentation issue for `valueBox()` and `infoBox()` in the render function section.
 Thanks @corderoortiz for reporting.
 - Fix #293: Navbar stays keeps white background, even when dark mode is selected/toggled. Related to a previous PR. Thanks to @JJohnson-DA for reporting.
-- Fix #290: don't set `data-toggle="tab"` when href is not NULL in `tabsetPanel()`. Thanks @veer0318 for reporting.
+- Fix #290: don't set `data-toggle="tab"` when `href` is not NULL in `tabsetPanel()`. Thanks @veer0318 for reporting.
 - Fix #243: `tabsetPanel()` id's not properly generated when inserting tabs to non-empty tabset. Thanks @DarkSideOfTheMat for reporting and giving hints.
 
 # bs4Dash 2.1.0

R/dashboardHeader.R

@@ -480,7 +480,7 @@ messageItem <- function(from, message, icon = shiny::icon("user"), time = NULL,
 #'   \item \code{teal}: \Sexpr[results=rd, stage=render]{bs4Dash:::rd_color_tag("#39cccc")}.
 #'   \item \code{olive}: \Sexpr[results=rd, stage=render]{bs4Dash:::rd_color_tag("#3d9970")}.
 #' }
-#' @param href An optional URL to link to.
+#' @param href An optional URL to link to. When inputId is set, href will be ignored.
 #' @param inputId Whether to allow the item to act as a \link[shiny]{actionButton}.
 #'
 #' @rdname dropdownMenu
@@ -504,9 +504,9 @@ notificationItem <- function(text, icon = shiny::icon("exclamation-triangle"),
       class = itemCl,
       `disabled` = if (is.null(inputId)) NA else NULL,
       href = if (is.null(inputId)) {
-        "#"
+        if (!is.null(href)) href else "#"
       } else {
-        href
+        "#"
       },
       target = if (is.null(inputId)) {
         if (!is.null(href)) "_blank"