AndNot: avoid returning bitmapcontainer with arraycontainer cardinality #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpot
commented
Aug 1, 2018
| seed := int64(42) | ||
| rand.Seed(seed) | ||
|
|
||
| trials := []trial{ | ||
| {n: 1010, percentFill: .50, ntrial: 10}, | ||
| {n: 8192, percentFill: .99, ntrial: 10}, |
There was a problem hiding this comment.
This had to be updated to set more bits or it would trip the new check in writeTo.
In some cases this could cause bitmaps to be serialized incorrectly. Check if a bitmap needs to be converted to an array container after an inplace-andNot operation. This also adds a sanity check when writing bitmap containers to make sure the cardinality is correct.
|
We could also validate that array containers have strictly increasing values which, I think, would have caught this on the deserialization side. I'm not sure if we want to be checking that every time we deserialize a bitmap though. I suppose we could add a |
|
Very good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases this could cause bitmaps to be serialized incorrectly.
Check if a bitmap needs to be converted to an array container after an
inplace-andNot operation.
This also adds a sanity check when writing bitmap containers to make
sure the cardinality is correct.