Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow php 8.3 and update deps #95

Merged
merged 10 commits into from
Sep 19, 2023
Merged

Allow php 8.3 and update deps #95

merged 10 commits into from
Sep 19, 2023

Conversation

fezfez
Copy link
Contributor

@fezfez fezfez commented Jun 17, 2023

  • phpunit ^10
  • doctrine/coding-standard ^12

@fezfez
Copy link
Contributor Author

fezfez commented Jun 19, 2023

see laminas/laminas-continuous-integration-action#130

@fezfez
Copy link
Contributor Author

fezfez commented Sep 15, 2023

https://github.com/maglnet/ComposerRequireChecker not ready yet for php 8.3

@fezfez
Copy link
Contributor Author

fezfez commented Sep 19, 2023 •
edited
Loading

@Ocramius -caused by No code coverage driver available and everything is update, do you know why this happen ?-

EDIT : ah never mind, its laminas/laminas-continuous-integration-action#130

@fezfez fezfez changed the title Update deps Allow php 8.3 and update deps Sep 19, 2023
@fezfez
Copy link
Contributor Author

fezfez commented Sep 19, 2023

ping @Ocramius 🥇

@Ocramius Ocramius self-assigned this Sep 19, 2023
@Ocramius Ocramius added the enhancement New feature or request label Sep 19, 2023
@Ocramius Ocramius added this to the 1.10.0 milestone Sep 19, 2023
Ocramius
Ocramius approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fezfez!

@Ocramius Ocramius merged commit cf30872 into Roave:1.10.x Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fezfez @Ocramius