[Feature] Define schema assets filter in configuration (continue) #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
reviewed
Feb 7, 2023
Ocramius
reviewed
Feb 7, 2023
e-vil-dev
force-pushed
the
schema-asserts-filter
branch
from
f279857 to
0b6aa54
Compare
Ocramius
approved these changes
Feb 8, 2023
example/full-config.php
Outdated
|
|
||
| SchemaAssetsFilter::class => static function (): callable { | ||
| /** | ||
| * @param AbstractAsset|string $asset |
There was a problem hiding this comment.
Note: we are on PHP 8.1 or newer, so we can use union types :D
example/full-config.php
Outdated
| @@ -193,6 +196,20 @@ | |||
|
|
|||
| DependencyFactory::class => DependencyFactoryFactory::class, | |||
| ConfigurationLoader::class => ConfigurationLoaderFactory::class, | |||
|
|
|||
| SchemaAssetsFilter::class => static function (): callable { | |||
There was a problem hiding this comment.
SchemaAssetsFilter is not a real class here, is it? Let's use a string, if it isn't.
example/full-config.php
Outdated
Comment on lines
203
to
212
| */ | ||
| return static fn (mixed $asset): bool => ! in_array( | ||
| $asset instanceof AbstractAsset ? $asset->getName() : $asset, | ||
| [ | ||
| 'sequence_to_generate_value', | ||
| 'table_without_doctrine_mapping', | ||
| ], | ||
| true, | ||
| ); |
There was a problem hiding this comment.
Let's expand the comment (since this is reference documentation) explaining that this is mostly filtering out the two tables that are listed in the closure
1. Fix 'Undefined array key "schema_assets_filter"' warning by add default config value
e-vil-dev
force-pushed
the
schema-asserts-filter
branch
from
0b6aa54 to
dae3ee1
Compare
|
@Ocramius Any further actions on this? Or just wait release?) |
|
Merged in #107 thank you @e-vil-dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue #36 on base of 3.10.x branch + unit tests
Add support
doctrine.configuration.{$name}.schema_assets_filterconfiguration value