Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a stricter range for PHP version in composer.json #57

Closed
wants to merge 1 commit into from

Conversation

edigu
Copy link
Contributor

@edigu edigu commented Jan 21, 2022

This PR restricts the php version range in composer.json to avoid potential mess as PHP introduces new BC breaks in minor releases.

Closes #56

@edigu edigu mentioned this pull request Jan 21, 2022
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @edigu!

@Ocramius
Copy link
Member

Oh, the lockfile probably needs reverting: try composer update --lock on the original version

@edigu
Copy link
Contributor Author

edigu commented Feb 1, 2022

Okay this is a bit sneaky. When I do a composer update --lock on the original version, lock file contains following diff:

diff --git a/composer.lock b/composer.lock
index 577c7f2..523f432 100644
--- a/composer.lock
+++ b/composer.lock
@@ -4,7 +4,7 @@
         "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",
         "This file is @generated automatically"
     ],
-    "content-hash": "74cefb769ea346e7d63d8d9cb057be6b",
+    "content-hash": "6314d7ee1d696d2ee9b265f34f9b5d9f",
     "packages": [
         {
             "name": "doctrine/cache",
@@ -5552,7 +5552,7 @@
     "prefer-stable": false,
     "prefer-lowest": false,
     "platform": {
-        "php": "^7.4 || ~8.0.0 || ~8.1.0"
+        "php": "^7.4"
     },
     "platform-dev": [],
     "plugin-api-version": "2.2.0"

Are we trying to have ^7.4 in lock and ^7.4 || ~8.0.0 || ~8.1.0 in composer.json intentionally or am I missing something else?

@Ocramius
Copy link
Member

Ocramius commented Feb 2, 2022

In theory, composer update --lock should copy the current platform to the lock file 🤔

You can also try composer update nothing

@Ocramius Ocramius added this to the 3.4.0 milestone Feb 15, 2022
@Ocramius Ocramius added the enhancement New feature or request label Feb 15, 2022
@Ocramius
Copy link
Member

Fixed in #64

@Ocramius Ocramius closed this Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency range is broken
2 participants