PSR-6 cache support #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ItemPoolInterface` instances Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
…on merges In `Roave\PsrContainerDoctrine\ConfigurationFactory`, the `doctrine/orm` configuration is assembled. That configuration has a nested array configuration for `second_level_cache` which also have defaults. Due to the array concatenation, nested array values are not applied and thus the configured defaults within the `ConfigurationFactory` are not applied. Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
- drops support for `doctrine/common` <3.2 - drops support for `doctrine/dbal` <3.3 - drops support for `doctrine/migrations` <3.4 - drops support for `doctrine/persistence` <2.3 Signed-off-by: Maximilian Bösing <[email protected]>
doctrine already conflicts itself with versions of `doctrine/annotations` <1.13 in `doctrien/orm` 2.11.x Signed-off-by: Maximilian Bösing <[email protected]>
boesing
commented
Feb 15, 2022
boesing
commented
Feb 15, 2022
boesing
commented
Feb 15, 2022
boesing
commented
Feb 15, 2022
boesing
commented
Feb 15, 2022
Signed-off-by: Maximilian Bösing <[email protected]>
This was referenced Feb 15, 2022
Merged
Ocramius
requested changes
Feb 15, 2022
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
This is also a requirement by `doctrine/*` components and thus can be omitted here since we do not implement that interface. Signed-off-by: Maximilian Bösing <[email protected]>
Ocramius
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the next major releases of
doctrine/dbalanddoctrine/orm, support fordoctrine/cachewill be dropped and only PSR-6 will be supported.To prepare this repository for that change, I'd like to add support for PSR-6 caches in this PR.
NOTE
This also drops support for various package versions:
doctrine/common<3.2doctrine/dbal<3.3doctrine/migrations<3.4doctrine/persistence<2.3