feat(exec-env): set non-legacy environment variables #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I tried using `emsdk` installed by the plugin to install the latest version of `emcc` (3.1.44), I noticed warnings being printed for legacy environment variables being used. Setting the recommended environment variables based on the old ones set by the plugin does the trick. ```console $ emcc --check legacy environment variable found: `LLVM`. Please switch to using `EM_LLVM_ROOT` instead` legacy environment variable found: `BINARYEN`. Please switch to using `EM_BINARYEN_ROOT` instead` emcc (Emscripten gcc/clang-like replacement + linker emulating GNU ld) 3.1.44 (bec42dac7873903d09d713963e34020c22a8bd2d) shared:INFO: (Emscripten: Running sanity checks) $ EM_LLVM_ROOT=$LLVM EM_BINARYEN_ROOT=$BINARYEN emcc --check emcc (Emscripten gcc/clang-like replacement + linker emulating GNU ld) 3.1.44 (bec42dac7873903d09d713963e34020c22a8bd2d) shared:INFO: (Emscripten: Running sanity checks) ```
|
Thanks a lot for catching this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tried using
emsdkinstalled by the plugin to install the latest version ofemcc(3.1.44), I noticed warnings being printed for legacy environment variables being used. Setting the recommended environment variables based on the old ones set by the plugin does the trick.