-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible with endroid/qr-code > 5.0.0 #114
Comments
I guess this line doesn't work for version 5 then?
Definitely open to PRs on this one. |
I will try to see if that is the only problem and then create a PR for this! if it is more work I dont have time right now and I will report back. |
This should fix it: #115 Don't currently have the time to test it with other versions then 4 and 5. |
Fix issue #114 (Support for EndroidQR v5)
@Mattie112 thanks for the PR and the patience for me to sort it out, feel free to close if everything is working as intended for you now |
Thanks, I will update to the latest version and confirm that it works. Thans for adding the test/build config, did not notice that :) |
Yes, all seem to be working fine (with Endroid v5). Great timing btw, I was just about to merge my internal MR but now I can set it back to this repo instead of my own fork :) Thanks again! |
When using this project with endroid/qr-code version 5.0.2 I get the following error:
With version 4.8.5 it works just fine.
The text was updated successfully, but these errors were encountered: