Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

endroid/qr-code compatibility issue #82

Closed
proxycheck opened this issue Nov 26, 2021 · 1 comment · Fixed by #84
Closed

endroid/qr-code compatibility issue #82

proxycheck opened this issue Nov 26, 2021 · 1 comment · Fixed by #84
Labels
bug help wanted

Comments

@proxycheck
Copy link

Using the latest TwoFactorAuth (v1.8.1) works perfectly with Endroid/qr-code v3.9.7 but it breaks if you try to use a more recent version. For instance v4.3.5, v4.4.0 or the very latest v4.4.1.

The error given is this:

PHP Fatal error: Uncaught Error: Class "Endroid\QrCode\ErrorCorrectionLevel" not found in vendor\robthree\twofactorauth\lib\Providers\Qr\EndroidQrCodeProvider.php:59
@willpower232
Copy link
Collaborator

Thanks for letting us know, it looks like their website is either broken or missing right now so not sure how much code change will be needed. Will keep this on my to-do list to have another look for a changelog or upgrade guide in the future.

Unless of course someone more knowledgable than me with endroid makes a PR in the meantime 😅

@MasterOdin MasterOdin mentioned this issue Dec 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix compatibility with endroid/qr-code 4
2 participants
@willpower232 @proxycheck