Fix compatibility with endroid/qr-code 4

[MasterOdin]

Closes #82

This PR adds compatibility with endroid/qr-code:^4 while maintaining support for older versions.

Test code:

<?php

use RobThree\Auth\Providers\Qr\EndroidQrCodeProvider;
use RobThree\Auth\Providers\Qr\EndroidQrCodeWithLogoProvider;

require_once(__DIR__ . '/vendor/autoload.php');

$filename = method_exists(\Endroid\QrCode\QrCode::class, 'create') ? 'test2.png' : 'test1.png';

$provider = new EndroidQrCodeProvider();
file_put_contents(__DIR__ . '/' . $filename, $provider->getQRCodeImage('foobar', 80));

$provider2 = new EndroidQrCodeWithLogoProvider();
$provider2->setLogo(__DIR__ . '/logo.jpeg', [30, 30]);
file_put_contents(__DIR__ . '/logo-' . $filename, $provider2->getQRCodeImage('foobar', 80));

logo.jpeg:

endroid/qr-code:^3 results:

endroid/qr-code:^4 result:

[willpower232]

if it works for you then that is great (I don't know endroid enough to test), my only critique would be the unnecessary else before return

[MasterOdin]

my only critique would be the unnecessary else before return

replaced.

if it works for you then that is great (I don't know endroid enough to test)

Yeah, that's why I included the test script in the OP to make it easy to verify, along with the generated images from running it. I have used various options to confirm they’ve work as well (setting different colors, image height / width, etc.).

[willpower232]

Thanks for that.

I'd like the php 8.1 thing to be resolved and then ship a release to fix both unless it takes too long to figure out and you need this fix shipping sooner 😅

I wonder if it is also worth creating another github workflow or two to specifically test against both versions of Endroid, and Bacon for that matter.

[MasterOdin]

What is done in other projects I work on is to have a workflow that installs the latest dependencies that work (what's currently happening here) and the lowest dependencies and makes sure the whole range works. A similar thing could be done here, sure.

Though need to also write a test suite for endroid and bacon at the same time.

[MasterOdin]

I'd like the php 8.1 thing to be resolved and then ship a release to fix both unless it takes too long to figure out and you need this fix shipping sooner

At this point, ideally a maintainer would be able to add the test I made to #83 and then merge it in relatively quickly, the pieces are all there.

[willpower232]

@MasterOdin it would be good to get your feedback on #86 as it would be a good way of testing both version 3 and 4 of endroid separately

[RobThree]

I'd like the php 8.1 thing to be resolved and then ship a release to fix both unless it takes too long to figure out and you need this fix shipping sooner

At this point, ideally a maintainer would be able to add the test I made to #83 and then merge it in relatively quickly, the pieces are all there.

Is there something I can do? I'm a bit unclear as what needs to still be done.

[willpower232]

@MasterOdin would you be able to rebase your branch (or merge master into it) and then you can set up a test for both version 3 and 4 as separate workflows?

[MasterOdin]

@willpower232 I've rebased the PR on top of the latest master, as well as added a minimal test suite that tests using the provider "works" across a range of PHP / dependency versions.

[willpower232]

thank you very much, I'll go over it shortly and get a release out