Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warning in PHP8 #89

Closed
Whip opened this issue Feb 14, 2022 · 6 comments
Closed

Deprecation warning in PHP8 #89

Whip opened this issue Feb 14, 2022 · 6 comments

Comments

@Whip
Copy link

Whip commented Feb 14, 2022

On PHP8, this warning is displayed when generating secret and QR code

Deprecated: rawurlencode(): Passing null to parameter #1 ($string) of type string is deprecated in ProjectFolder\vendor\robthree\twofactorauth\lib\TwoFactorAuth.php on line 275
@willpower232
Copy link
Collaborator

We've had this fixed in master, but I was trying to wait for #84 before releasing. I'll try and get it finished and released today.

@willpower232
Copy link
Collaborator

all done :-)

@Whip
Copy link
Author

Whip commented Mar 3, 2022

Composer is still not picking up this version. Is this normal? I'm running composer update. The version I have is 1.8.

@willpower232
Copy link
Collaborator

1.8.1 is showing up in packagist https://packagist.org/packages/robthree/twofactorauth

do you need to do composer require robthree/twofactorauth ^1.8.1 ?

@Whip
Copy link
Author

Whip commented Mar 3, 2022

That worked. Thanks

@willpower232
Copy link
Collaborator

good to know, unfortunately composer update needs a helping hand sometimes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@willpower232 @Whip