-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyOpenSci REVIEW - extract static classes and transfer to own modules #45
Conversation
Codecov ReportBase: 86.70% // Head: 86.47% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
- Coverage 86.70% 86.47% -0.24%
==========================================
Files 11 12 +1
Lines 820 806 -14
==========================================
- Hits 711 697 -14
Misses 109 109
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This PR addresses one of the comments of reviewer @Batalex in PyOpenSci:
I guess I got caught up with the idea of using static classes to group functions. Makes more sense to write a module for each class since that is the pythonic way.