add parameter to allow the setting of running user for container #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@n-marton |
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
By it self that "user" param is not inherited into the containerd params, but I have adjusted my change to make it so. So the running user of the container now comes from the task's user config. edit: also, yes I agree it should be this way instead of introducing a new config param. |
|
@n-marton Can you read and sign the CLA? |
|
I have read the CLA Document and I hereby sign the CLA |
jonathanrcross
added a commit
to AtomicConductor/nomad-driver-containerd
that referenced
this pull request
Jan 14, 2022
* add parameter to allow the setting of running user for container (Roblox#120) * add parameter to allow the setting of running user for container * use task level user param as source param * Security fixes: upgrade containerd + nomad. (Roblox#122) Signed-off-by: Shishir Mahajan <[email protected]> Co-authored-by: n-marton <[email protected]> Co-authored-by: Shishir <[email protected]> Co-authored-by: Jonathan Cross <>
jonathanrcross
added a commit
to AtomicConductor/nomad-driver-containerd
that referenced
this pull request
Jan 25, 2022
* add parameter to allow the setting of running user for container (Roblox#120) * add parameter to allow the setting of running user for container * use task level user param as source param * Security fixes: upgrade containerd + nomad. (Roblox#122) Signed-off-by: Shishir Mahajan <[email protected]> * Fix issue Roblox#116 - allow relative paths in mounts. (Roblox#123) * Fix issue Roblox#116 - allow relative paths in mounts. * Add test. Signed-off-by: Shishir Mahajan <[email protected]> * fix entrypoint override (Roblox#124) In case of entrypoint override, image config needs to be passed. * rename test file numbers Co-authored-by: n-marton <[email protected]> Co-authored-by: Shishir <[email protected]> Co-authored-by: Jonathan Cross <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it comes handy form time to time to override the running user of a container