This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Add getDerivedStateFromProps #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPGhatguy
reviewed
Apr 4, 2018
lib/Component.spec.lua
Outdated
|
|
||
| local handle = Reconciler.reify(Core.createElement(TestComponent, { | ||
| visible = true | ||
| })) |
There was a problem hiding this comment.
We can merge these two tests just by adding the two lines of assertion here I think.
There was a problem hiding this comment.
Fixed now!
|
I'll handle the changelog and documentation -- I want to hold off on the latter until I actually get a chance to try porting Roact-Rodux to use this! |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53.
Adds a static class function,
getDerivedStateFromProps, that is invoked when a component instance is created and when properties change. This function receives two arguments:newProps, the new properties table, andcurrentState, the component's current state (note that in cases where rendering causes both properties and state to change,currentStatewill equal the new state - I'm not sure if this happens in practice).getDerivedStateFromPropsmay return either a table ornil; if it returns a table, the table is merged into the state without triggering another re-render. This is called before any lifecycle hooks invoke, includingwillUpdate.