Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit fixes to build mimick_vendor on Windows locally #29

Merged
merged 5 commits into from
Dec 12, 2022

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Dec 11, 2022

Debug #28 .

@Tobias-Fischer
Copy link
Contributor

I found that some builds fail in the PRs but build okay on the main branch - feel free to commit there, too.

@Tobias-Fischer Tobias-Fischer mentioned this pull request Dec 11, 2022
@traversaro traversaro changed the title Only build mimick_vendor Commit fixes to build mimick_vendor on Windows locally Dec 11, 2022
@traversaro
Copy link
Member Author

I was not unable to fix #28 . Anyhow, I commit the fixes that were necessary to build the package in #21 (comment) , that are mainly:

  • Patch to use FetchContent instead of ExternalProject on Windows: the build is already quite error-prone on Windows, at least we can avoid all the logic of manually forwarding options and parameters by using FetchContent and building mimick directly as part of the mimick_vendor project
  • Use the commit corresponding to Fix detection of 64-bit for Visual Studio 2019 and 2022 ros2/Mimick#25

@Tobias-Fischer
Copy link
Contributor

Thanks @traversaro - I will see whether this actually builds on the Windows CI first; if not, I will upload your pre-built package.

@Tobias-Fischer Tobias-Fischer merged commit 17f076a into RoboStack:main Dec 12, 2022
@Tobias-Fischer
Copy link
Contributor

It built fine in CI - thanks so much @traversaro!

@wolfv
Copy link
Member

wolfv commented Dec 12, 2022

Wow, awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants