tools: Remove global subdirs from installer #16430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relevant to: RobotLocomotion#7331 At best, the subdirs tracking was an optimization; at worst, a temptation to TOCTOU errors. Removing it is another baby step toward testability.
rpoyner-tri
added
release notes: none
rpoyner-tri
commented
Jan 25, 2022
There was a problem hiding this comment.
+@jwnimmer-tri for both reviews.
+(status: single reviewer ok)
+(release notes: none)
Reviewable status: LGTM missing from assignee jwnimmer-tri(platform) (waiting on @jwnimmer-tri)
There was a problem hiding this comment.
🎵🎵 99 bottles of mutable globals on the wall, 99 bottles of globals..., take one down, pass it around, ... 8d7faskjhawj3ky;A^A$#WRA+++ATH no carrier
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee jwnimmer-tri(platform) (waiting on @rpoyner-tri)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant to: #7331
At best, the subdirs tracking was an optimization; at worst, a
temptation to TOCTOU errors. Removing it is another baby step toward
testability.
This change is