Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[allegro_hand_description] Move related Drake files into here #40

Merged

Conversation

jwnimmer-tri
Copy link
Contributor

@jwnimmer-tri jwnimmer-tri commented Mar 24, 2024

This were copied from Drake as of 665721e9.

Twin PR: RobotLocomotion/drake#21184


This change is Reviewable

@jwnimmer-tri
Copy link
Contributor Author

+@rpoyner-tri for both reviews, please. The related Drake PR is linked in the description above.

Note that since this is only adding files, we can merge this PR anytime -- we don't need to sync the merging with the other PR concurrently.

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all discussions resolved, LGTM missing from assignee rpoyner-tri, platform LGTM missing (waiting on @jwnimmer-tri)

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all discussions resolved, platform LGTM from [rpoyner-tri] (waiting on @jwnimmer-tri)

This were copied from Drake as of 665721e9.
@jwnimmer-tri jwnimmer-tri force-pushed the mv-allegro-hand-models branch from bc04479 to 7991d82 Compare March 25, 2024 15:31
@jwnimmer-tri jwnimmer-tri merged commit 199f3e5 into RobotLocomotion:master Mar 25, 2024
2 checks passed
@jwnimmer-tri jwnimmer-tri deleted the mv-allegro-hand-models branch March 25, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants