[realsense2_description] Move Drake files into here #43
Conversation
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, platform LGTM missing (waiting on @jwnimmer-tri)
a discussion (no related file):
Working
We will use a merge commit here (not squash).
There was a problem hiding this comment.
+@rpoyner-tri for both reviews, please. Note that the commits are curated, which should help both the review and the git history later on.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee rpoyner-tri, platform LGTM missing (waiting on @rpoyner-tri)
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 4 of 4 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status: 2 unresolved discussions, platform LGTM from [rpoyner-tri] (waiting on @jwnimmer-tri)
realsense2_description/urdf/customize.sed line 1 at r3 (raw file):
s|$(find realsense2_description)/urdf/||;
nit TIL that $ does not act as a special character, unless it is at the end of an expression (or subexpression (GNU)). Maybe worth a comment?
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, platform LGTM from [rpoyner-tri] (waiting on @rpoyner-tri)
a discussion (no related file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Working
We will use a merge commit here (not squash).
In progress.
realsense2_description/urdf/customize.sed line 1 at r3 (raw file):
Previously, rpoyner-tri (Rick Poyner (rico)) wrote…
nit TIL that
$does not act as a special character, unless it is at the end of an expression (or subexpression (GNU)). Maybe worth a comment?
Done
Twin PR: RobotLocomotion/drake#21191
This change is