-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROS2 support #7
Merged
cmastalli
merged 18 commits into
RobotMotorIntelligence:main
from
cmastalli:topic/ros2-migration
Jul 7, 2023
Merged
ROS2 support #7
cmastalli
merged 18 commits into
RobotMotorIntelligence:main
from
cmastalli:topic/ros2-migration
Jul 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@wxmerkt -- I cannot provide feedback on ROS 2 migration/support. Your support/feedback is very appreciated here. Moreover, I need help regarding migrating our rostest to ROS2. ATM, I am unsure how to do it. |
james-p-foster
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff! LGTM.
This reverts commit 6c7813c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows the migration pattern propoded in loco-3d/whole_body_state_msgs#10.
However, it was needed to modify SolverStatistics msg as ROS2 doesn't have a great support with time msgs.