Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2 support #7

Merged
merged 18 commits into from
Jul 7, 2023

Conversation

cmastalli
Copy link
Collaborator

This PR follows the migration pattern propoded in loco-3d/whole_body_state_msgs#10.

However, it was needed to modify SolverStatistics msg as ROS2 doesn't have a great support with time msgs.

@cmastalli
Copy link
Collaborator Author

cmastalli commented Jul 5, 2023

@wxmerkt -- I cannot provide feedback on ROS 2 migration/support. Your support/feedback is very appreciated here.

Moreover, I need help regarding migrating our rostest to ROS2. ATM, I am unsure how to do it.

@cmastalli cmastalli requested a review from james-p-foster July 5, 2023 20:55
@cmastalli cmastalli marked this pull request as draft July 5, 2023 22:05
@cmastalli cmastalli marked this pull request as ready for review July 5, 2023 22:05
Copy link
Contributor

@james-p-foster james-p-foster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff! LGTM.

@cmastalli cmastalli merged commit 26818d3 into RobotMotorIntelligence:main Jul 7, 2023
@cmastalli cmastalli deleted the topic/ros2-migration branch July 7, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants