unsubscribe TF listeners for InteractiveMarkers and SceneNodes #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes RobotWebTools#69 The ongoing TF subscription was preventing the GC from collecting InteractiveMarkerHandles, even after InteractiveMarkerClient.eraseIntMarker() was called.
…SceneNode is destroyed this way, no lingering TF listeners should be left to leak memory (see RobotWebTools#105 )
rctoris
added a commit
that referenced
this pull request
Oct 22, 2015
unsubscribe TF listeners for InteractiveMarkers and SceneNodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #105 and #69, InteractiveMarkers and Markers can leak memory via their TF callbacks.
This pull request adds an
unsubscribeTf()function toInteractiveMarkerHandleandSceneNodeto remove those callbacks.Two places remain where leaks are possible: the
UrdfandParticleclasses. However, both currently never overwrite their SceneNodes, so they should be safe for now.