show scenenodes only after they've received a Tf #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 8, 2016 14:16
This prevents the ugly showing up of markers/URDFs at the wrong place until they've received a TF
|
Should we make this optional? I feel like in some cases, much like RVIZ does, a bunch of stuff rendered in the center is a good indication you don't have TFs coming through like you think you do. |
|
I personally think nothing showing up at all is an even better sign that TFs are not coming through. Especially for short-lived markers, it's very distracting to have them in the wrong place for a third of their lifetime. |
|
👍 makes sense, I agree totally. I think it was left over from a legacy of mimicking rviz. |
rctoris
added a commit
that referenced
this pull request
Mar 11, 2016
show scenenodes only after they've received a Tf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's also one more fix to
unsubscribeTf, sorry about that