Fix for ROS3D.Viewer clear color, use parseInt in order to convert hex s... #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x string to number.
|
Build failing due to missing parameter in |
|
Oh stupid me. Radix must be 16. Will update my request now |
rctoris
added a commit
that referenced
this pull request
Nov 10, 2014
Fix for ROS3D.Viewer clear color, use parseInt in order to convert hex s...
k-aguete
pushed a commit
to k-aguete/ros3djs
that referenced
this pull request
Oct 21, 2022
Also add back build folder, so users can do ```bower install roslibjs#develop``` - this should also put RobotWebTools#85 and RobotWebTools#86 to rest. [ ] [Register](http://bower.io/#registering-packages) roslibjs with bower
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear color was always (0,0,0) here. I had to convert the string representation
of the hex number to int and call setClearColorHex to get the clear color working.