Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass of stable release #9

Merged
merged 31 commits into from
Mar 29, 2013
Merged

First pass of stable release #9

merged 31 commits into from
Mar 29, 2013

Conversation

rctoris
Copy link
Contributor

@rctoris rctoris commented Mar 28, 2013

First pass of a "stable" release. Includes:

  • 3D URDF
  • Interactive Markers
  • Markers
  • Scene nodes
  • Examples
  • JSDOC
  • ROS3D namespaces
  • build script

EDIT: 🐕

@baalexander
Copy link
Contributor

Holy 🐄!

I'm about to head out to the WebGL meetup in SF, but will review this tonight or tomorrow morning. LINE BY LINE.

@rctoris
Copy link
Contributor Author

rctoris commented Mar 28, 2013

@baalexander I hope you enjoy some 🍻 at said meetup...

@jihoonl
Copy link
Member

jihoonl commented Mar 28, 2013

Lol

@rctoris
Copy link
Contributor Author

rctoris commented Mar 29, 2013

rctoris added a commit that referenced this pull request Mar 29, 2013
First pass of stable release
@rctoris rctoris merged commit 82616d5 into RobotWebTools:devel Mar 29, 2013
@rctoris
Copy link
Contributor Author

rctoris commented Mar 29, 2013

r2-devel started in devel branch and stable branch also started with this merge.

@baalexander
Copy link
Contributor

I read through the completed code (the diff was a little overwhelming).

3D is far from my areas of expertise, so I'm going to ask @dgossow on Monday to take a look and if you're onsite @rctoris, hopefully y'all will get a chance to discuss. A couple things:

  • Thanks for conforming the code to the style guide, it makes it much easier to read.
  • Are we using UrdfClient.js in app code? Yes, in urdf.html apparently.
  • Does the ColladaLoader we include differ from three.js' ColladaLoader. I know it used to, but not sure if still the case since David sent a couple patches in.

@baalexander
Copy link
Contributor

Also, @dgossow, @jkammerl, and I demoed interactive markers and depth cloud rendering in the browser yesterday at the Khronos WebGL meetup to much applause. It was pretty sweet as these guys are the ones implementing WebGL in the browsers as well as creating awesome demos.

We let them know to see github.com/robotwebtools for more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants