[PINT-2541] readme review #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvkedia
approved these changes
Oct 9, 2023
arleyl
approved these changes
Oct 9, 2023
Co-authored-by: Arley Lewis <[email protected]>
MayankR
added a commit
that referenced
this pull request
Dec 6, 2023
* [ENT-2819] Robust Intelligence AI firewall integration initial commit (#1) * initial commit for check * check with correct metrics * add dashboard * update dashboard and readme * update dashboard title * fix readme links and add logos * fix support email link * update homepage and support email * [END-2821] Update README (#2) * update section on metrics collected * update firewall link and dashboard * [PINT-2462] readme fixes (#3) * readme fixes * update risk name * fix metrics section content * add image assets * [PINT-2485] PR build issues (#4) * lint fixes * add sales email * [PINT-2485] Address PR comments (#5) * update overview and description * add integrtaion version * add classifier tags * add dashboard description * add dashboard to manifest (#6) * [PINT-2541] readme review (#7) * add details to configure section * Add suggestion Co-authored-by: Arley Lewis <[email protected]> --------- Co-authored-by: Arley Lewis <[email protected]> * [PINT-2618] PR feedback and dashboard update (#8) * update readme and remove unnecessary file * upgrade dashboard * [PINT-2651] add dashboard banner image (#9) * add dashboard banner * update banner url * address PR comments (#10) * update description (#11) * [PINT-2719] readme and dashboard image (#12) * update dashboard image and description * update firewall image * update image ratio (#13) * [PINT-2891] add scope variable to dashboard (#14) * add scope variable * fix description * remove folder (#15) * fix import (#16) * run ddev validate ci * fix codecov * remove assets that are not required * add metrics check * add codeowners * fix format * remove non ascii character * fix test * add test --------- Co-authored-by: Arley Lewis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addressing feedback received here DataDog#2122 (review)
Motivation
What inspired you to submit this pull request?
Review checklist
no-changeloglabel attachedAdditional Notes
Anything else we should know when reviewing?