Collapse Filterable and Sortable into Declarative Filters #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flattens the methods that are exposed to controllers into a single mix. If anyone opens this class, they can see the method signatures and documentation in one place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Filterable and Sortable mixins were mixed into the DeclarativeFilters module. This meant anyone interested in seeing the method definitions had to drill twice. It also prevented the Ruby LSP from being able to show hover comments and support the Go To Definition function. Collapsing the mixins simplifies this and enables hover previews:
This also includes updates to the markdown in the comments (and some new comments) to better take advantage of the hover preview.