[Bug] Comment Multiline Input Field state isn't getting reset once the comment has been Send

[Nabhag8848]

What happened?

• Comment Multiline Input Field state isn't getting reset once the comment has been Send. it should reset the field to empty string.

Steps to reproduce

1. run '/notion comment'
2. select page and comment on page.
3. see the comment input field.

Relevant ScreenShots

Screen.Recording.2024-01-21.at.09.39.02.mov

Version

v6.5

What browsers are you seeing the problem on?

Chrome

[brf153]

@Nabhag8848 capabilities of my integration are

Still, I am not being able to make comments on a page.

[Nabhag8848]

@Nabhag8848 capabilities of my integration are

Still, I am not being able to make comments on a page.

connect again maybe you didn't have capabilities when you connected and please please please make sure you are working on one issue at a time.

[brf153]

You mean that I should refresh the page or should I use the command of rc-apps deploy url username password again?

[brf153]

Yeah I am working on the pagination one. I have made the recursive functions. I just need to check whether they are working fine or not. This issue seems easier than that one so I thought of making a pr for this one first.

[Nabhag8848]

Yeah I am working on the pagination one. I have made the recursive functions. I just need to check whether they are working fine or not. This issue seems easier than that one so I thought of making a pr for this one first.

In my opinion, prioritise that first and come up with this later, this will make things easier for us for reviewing.

[Nabhag8848]

You mean that I should refresh the page or should I use the command of rc-apps deploy url username password again?

connect again /notion connectmaybe you didn't have capabilities when you connected and please please please make sure you are working on one issue at a time.

[brf153]

@Nabhag8848 oki

[brf153]

I will finish the previous one first

[VipinDevelops]

Hello, @Nabhag8848, I'm interested in working on this issue.

[brf153]

@VipinDevelops I was actually working on this issue

[Sayan4444]

Hi @Nabhag8848 when we click submit,the input text should be equals=''. This feature is already implemented but its only clearing the input field value from the server and not from the client i.e. after sending a message you cant send the same message again as you cant send a emtpy message. I demonstrated it in the below video.

2024-01-29.00-36-53.mp4

If there is a function or a way in which we can also update the client side when the its server side value is changed i.e. we force the input field controlling it from the server, then it should work

[Nabhag8848]

Hi @Nabhag8848 when we click submit,the input text should be equals=''. This feature is already implemented but its only clearing the input field value from the server and not from the client i.e. after sending a message you cant send the same message again as you cant send a emtpy message. I demonstrated it in the below video.

2024-01-29.00-36-53.mp4
If there is a function or a way in which we can also update the client side when the its server side value is changed i.e. we force the input field controlling it from the server, then it should work

@Sayan4444 Yep. you got the point. #43 this issue is affecting this too. we have viewErrors everywhere but currently for some reason its not working. handleCommentInputAction is the custom method which is having the logic where we are storing the state on dispatch action of keyboard click when the input comment is written. try to get where this is called and most probably the state isn't resetting when comment is made.

Edited: Check i believe there is an issue around intialvalue of this comment Multiline input element

[Sayan4444]

@Nabhag8848 handleCommentInputAction is called for every keystrokes we make but we want to this delete the input field text for submit. Moreover input field state can be reset anywhere using this

await modalInteraction.clearInputElementState(
CommentPage.COMMENT_INPUT_ACTION
);

2024-01-29.01-19-30.mp4

I hope my explaination is good enough and do tell me if I lack any understanding

[Nabhag8848]

@Nabhag8848 handleCommentInputAction is called for every keystrokes we make but we want to this delete the input field text for submit. Moreover input field state can be reset anywhere using this

await modalInteraction.clearInputElementState( CommentPage.COMMENT_INPUT_ACTION );

2024-01-29.01-19-30.mp4
I hope my explaination is good enough and do tell me if I lack any understanding

Yep but i believe we are clearlying the input on action of comment, issue lies somewhere else.