Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added progress bar to toast messages for better UI experience #903

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dhairyashiil
Copy link
Contributor

Brief Title

Added progress bar to toast messages for better UI experience

Acceptance Criteria fulfillment

  • Combine progress bar with toast messages so that the progress bar duration matches the time the toast message stays on the screen.
  • Ensure the progress bar is dynamically adapted to both light and dark themes.
  • Implement border radius for the progress bar to match the toast message style.
  • The color of the progress bar should match the toast message's color palette:
  • For light theme, the progress bar will be a darker tone.
  • For dark theme, the progress bar will be a lighter tone.

Fixes #902

Video/Screenshots

light.theme.toast.message.mp4

and

dark.theme.curve.variant.toast.message.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-903 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@Spiral-Memory
Copy link
Collaborator

Looks like a good addition @dhairyashiil

Can we please have completely round in Curve variants, like was before :

image

image

@Spiral-Memory Spiral-Memory added the nudge minor tweaks suggested label Jan 27, 2025
@dhairyashiil
Copy link
Contributor Author

Hello @Spiral-Memory , so are you suggesting removing the progress bar for Curve variants, or do you want a completely round shape along with the progress bar?
Which option—first or second?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nudge minor tweaks suggested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Progress Bar for Toast Messages
2 participants